added static ipc support and configurabe dynamic ipc support #4
Conversation
| } | ||
| opts.read_options(options, "discord") | ||
|
|
||
| local function get_temp_path() |
There was a problem hiding this comment.
What does this get_temp_path() function do?
If it's for getting the system's temporary directory, I think it's better to handle it in main.go.
There was a problem hiding this comment.
I think it would be even better if we allow users to also customise the static path of the IPC socket, not just the dynamic path.
This can be done by using the use_static_socket_path option to determine whether the user wants to use a dynamic path or not. Then, the socket_path option will be regarded as the absoulute path of the IPC socket (e.g. /tmp/mpvsocket). Otherwise, the socket_path option will be used as the path prefix (which ponits to a directory) for placing the IPC socket with a dynamic filename containing the pid (e.g. mpv-discord-1234).
EDIT: This approach allows better flexibility to let users decide where the socket should be placed, and leaves the job of creating the dynamic_ipc_prefix directory to the users so that the code can be less complex as we don't have to deal with Windows filesystem compatibility.
|
I'm gonna work on this myself to implement your suggestions. Thanks anyway for your ideas! |
+ added two options to config + allow the IPC socket path to be static
Added support for configuring weather a dynamic or static ipc socket should be used, with the abilitu to configure where
the dynamic ipc socket should be created. It would potentially also make sense to enable configuring the path of the static
ipc socket, though that seems less usefull to me since that is typically set to /tmp/mpvsocket.
I tested this on linux, in combination with SVP, and as long as both are configured the same way
(either both use /tmp/mpvsocket or both use /tmp/mpvSockets/$PID), they work flawlessly with each other.
I did not test on macos or windows, as I currently dont have these OS available to me.
macos should work out of the box, though windows might be tricky.