feat: better dynamic ipc path naming #46
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sitiom
changed the title
/tmp/ on socket path in Windows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use_static_socket_pathoption in the config, allow inserting{pid}in thesocket_pathinstead (i.e.,socket_path=mpvsocket_{pid}). This allows you to set a custom dynamic name for the IPC (so it can match other plugins).socket_pathin Windows tompvsocket. MPV plugins usually expect the socket path to be on\\.\pipe\mpvsocketinstead of\\.\pipe\tmp\mpvsocket. This uses the same platform detection function in A default binary_path located at the mpv config path without the need to manually edit it in every time. Potentially fixes #12, #22 and #33 #35