Add 'callback' feature, with some other changes #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there is no way to handle erros should a command not run successfully. I've added the use of subprocess.PIPE, and a callback feature to Pool.run(). Here's an an example use case:
And looks like:
There are some other changes in there... such as adding the 'wait_time' option to Pool() as there was previously no way to alter that. I've also refactored how commands are processed by replacing 'next_command()' with an iterator object allowing the 'run()' loop to simply call 'process_commands.next()' rather than popping commands off a list and what not.
Please let me know if you have any questions about any of that.