-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed broken extract function #104
Conversation
…ed test solr sever from 4.1.0 to 4.6.0. All tests pass
@@ -425,7 +425,7 @@ def test_optimize(self): | |||
self.solr.optimize() | |||
self.assertEqual(len(self.solr.search('doc')), 4) | |||
|
|||
@unittest.expectedFailure | |||
#@unittest.expectedFailure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Absolutely. Forgot to remove it. |
This looks good to me – have you tested it on anything older than Solr 4.6? I'm wondering whether this is a compatibility issue for the 3.x series & will test that shortly |
I suspect the test started to break 5 months ago after commit 1322bff |
I take it back. Assuming people ran unit tests after the commit 1322bff, something must have been changed since then. It could be Solr 3.x vs 4.x. I will run some testing. |
Tested against 4 releases of Solr (4.6.0, 4.1.0, 3.6.2, 3.5.0), the result is the same. Without this patch, |
Did you run the full test suite to confirm that nothing else stopped working? It looks like Solr 3.6 is also fine in my admittedly modest testing |
All tests in the test suite pass against 4.6.0 and 4.1.0. However when I tested against 3.6.2 and 3.5.0, some tests were failing with or without my patch. So I assume it is my Solr server configuration and has nothing to do with the code change. Here is the test result for 3.5.0 with my patch (one more error without my patch though):
|
Without my patch,
|
Fix content extraction (thanks @tongwang)
Until pysolr 3.1.1 ships there's no point in running the Solr content extraction tests because they'll fail: django-haystack/pysolr#104
fixed both issues #96 and #90 and updated test solr sever from 4.1.0 to 4.6.0. All tests pass.