Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Severed last ties between Resource and Django #85

Merged
merged 1 commit into from Nov 14, 2016

Conversation

ElSaico
Copy link
Collaborator

@ElSaico ElSaico commented Jun 28, 2016

build_response now throws a NotImplementedError by default, while request_method and request_body are not called "Django-specific" on the documentation since multiple subclasses use them as-is.

Making it pure WSGI by default would need a separate Resource (hint!), since it needs to wrap the entire request-response cycle.

@coveralls
Copy link

coveralls commented Jun 28, 2016

Coverage Status

Coverage increased (+0.7%) to 96.714% when pulling 27859c8 on CraveFood:generic-resource into a4994eb on toastdriven:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.7%) to 96.714% when pulling 27859c8 on CraveFood:generic-resource into a4994eb on toastdriven:master.

@ElSaico ElSaico merged commit e600743 into toastdriven:master Nov 14, 2016
@ElSaico ElSaico deleted the generic-resource branch November 14, 2016 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants