Django >= 1.10 Compatibility #88
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- contidional import and return urls for Django >= 1.10, since patterns removed in 1.10
seocam
requested changes
Nov 7, 2016
| from django.conf import settings | ||
| from django.conf.urls import patterns, url | ||
|
|
||
| if get_django_version() >= '1.10.0': |
There was a problem hiding this comment.
This comparison might fail in some circumstances. Please see http://stackoverflow.com/questions/11887762/compare-version-strings
There was a problem hiding this comment.
@seocam will be working on this.
🏃♂️
| url(r'^(?P<pk>\d+)/$', cls.as_detail(), | ||
| name=cls.build_url_name('detail', name_prefix))] | ||
|
|
||
| if get_django_version() >= '1.10.0': |
django>=1.10 compatibility test initialized.
1 similar comment
|
Seems that Python 2.7 and 3.4 tests passed.
see: http://stackoverflow.com/a/34648720/1766716 https://travis-ci.org/toastdriven/restless/jobs/173916340#L267 |
|
@guneysus maybe just a rebase will work. I saw that we are not testing 3.3 on the travis file. What do you think? |
|
Master should now be compatible with django 1.10 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.