Fix settings import #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixed all the imports (global_settings needs to be imported for settings injection in codespeed.__init__)
- Only adding "default" Branch if not there yet
- works from tool dir if DJANGO_SETTINGS_MODULE is set. Otherwise, works from Django project dir
- Same as in create_branch.py script
- Maybe could be factored out if migrations get more complicated
|
I just used create_trunks and migrate_script and they worked perfectly (after being copied to the project dir). Thanks a bunch! |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While converting Codespeed into a Django app I missed the convert scripts to upgrade old installations. Here is the fix for that. I moved the scripts into the tools directory. Maybe they could be moved to a migrations dir... As always, I'm happy to change things as requested.