Skip to content
This repository has been archived by the owner on May 11, 2020. It is now read-only.

add more image information (Dockerfile/README) in UI #18

Closed
larrycai opened this issue Jan 13, 2015 · 7 comments
Closed

add more image information (Dockerfile/README) in UI #18

larrycai opened this issue Jan 13, 2015 · 7 comments
Milestone

Comments

@larrycai
Copy link
Collaborator

Dockerfile & README is very important for docker image.

we need to find a way to find it out, not for all docker image, but show it out if we can

Solution 1: Find the information in Docker image

Ask docker image maintainer to keep Dockerfile/README.md inside docker image, which is a good practice for public image

ADD . /app 

Solutin 2: use external system

Like wiki system we implemented before.

Other good idea ?

@larrycai larrycai added this to the 0.3.0 milestone Jan 13, 2015
@larrycai
Copy link
Collaborator Author

Yes, as we discussed in https://gitter.im/tobegit3hub/pirate , it shall use registry API.

I just think this feature looks very good, if we can find the simple solution to do this, we maybe provide it before ready of the API.

We can also know what could be useful in enterprise for the image sharing

@larrycai
Copy link
Collaborator Author

What I want now is (mostly same as dockerhub)

  • who build the package ?
  • is it automated build or manual upload ?
  • If it is automated, I want to see the CI job, Dockerfile
  • README.md for the docker image
  • Stable
  • popular ?
  • What is last updated

Anything else, maybe this information can be put into index server

@larrycai
Copy link
Collaborator Author

So far for solution 1 is like below

 $ docker run -v /registry:/tmp/registry registry
 $ docker run -v /registry:/registry pirate

So pirate will be able to access the registry data directly (yes, ugly), then we can check 4-5 layers of easy docker image to find Dockerfile/README.md in specific path like app.

larrycai added a commit that referenced this issue Jan 17, 2015
it can check 6 layers for /app/README.md now based on image id
wait for the GUI part
so far it is run in UI images/<id>/info
check nginx-registry image
sdd330 pushed a commit to sdd330/pirate that referenced this issue Jan 18, 2015
it can check 6 layers for /app/README.md now based on image id
wait for the GUI part
so far it is run in UI images/<id>/info
check nginx-registry image
@sdd330 sdd330 mentioned this issue Jan 19, 2015
larrycai added a commit that referenced this issue Jan 20, 2015
new structure for the imageinfo
some data are faked so far
larrycai added a commit that referenced this issue Jan 20, 2015
1. Dockerfile is checked like README.md, either of them is found in one layer, check is finished
2. image information is checked and passed back
larrycai added a commit that referenced this issue Jan 21, 2015
Update image info page according to the design, ref #18
@larrycai
Copy link
Collaborator Author

So far we plan to have information from

From image layer,

  • /app/PIRATE.ini for all user information, may overlap with standard registry API
  • /app/README.md for README
  • /app/Dockerfile for Dockerfile
  • /app/BUILD.log for CI build log

They shall exist in upper layer (so far searched for 5 layers) by travelling with parent id

@larrycai
Copy link
Collaborator Author

for /app/PIRATE.ini, it will be .ini format to be easily read.

# package version is for this spec, used for upgrade when needed
PACKAGE_VERSION=0.3

# some important logs for the build and general information
README=/app/README.md
DOCKERFILE=/app/Dockerfile

# build information for reference
BUILDLOG=/app/BUILD.log
BUILDLINK=http://jenkins.example.com/jobs
BUILDURL=http://jenkins.example.com/jobs/123

# source base
SOURCEURL=http://gerrit.example.com/gblit/ABC
SOURCE_COMMIT=788271625626

# tag is the tag pushed to registry as this image created.
TAG=20150102-SNAPSHOT,LATEST,SPRINT-1

# some admin CM stuff ?
VERSION=DOKK-15001
ORGANIZATION=DOKK

What else ?

@larrycai
Copy link
Collaborator Author

try to close this issue since some important data are already there, the DOCKER.pkg file could be used in next release.

@tobegit3hub @sdd330 please try it locally and give comments.

GUI will be improved before 0.3.0 release

@larrycai
Copy link
Collaborator Author

PR #33, and it is good enough for this release, close it now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant