Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Oreo adaptive icon shape #7

Closed
532910 opened this issue Dec 19, 2018 · 6 comments
Closed

Oreo adaptive icon shape #7

532910 opened this issue Dec 19, 2018 · 6 comments
Labels
enhancement New feature or request
Milestone
2.1.0

Comments

@532910
Copy link

532910 commented Dec 19, 2018

Please add support for icon shape

https://developer.android.com/guide/practices/ui_guidelines/icon_design_adaptive.html
https://material.io/guidelines/style/icons.html
@tobexyz tobexyz added the enhancement New feature or request label Dec 22, 2018
tobexyz added a commit that referenced this issue Dec 28, 2018
@tobexyz
wip issue #7 adaptive icon shape
1609835
tobexyz added a commit that referenced this issue Dec 29, 2018
@tobexyz
issue #7 adaptive icon shape
f9c1163
tobexyz added a commit that referenced this issue Dec 29, 2018
@tobexyz
issue #7 adaptive icon shape
3a56407
tobexyz added a commit that referenced this issue Dec 29, 2018
@tobexyz
Merge pull request #10 from tobexyz/ui
842fcc2 
issue #5 #7 #8
@tobexyz tobexyz added this to the 2.1.0 milestone Dec 29, 2018
@tobexyz
Copy link
Owner

tobexyz commented Dec 29, 2018

it's hopefully implemented in release 2.1.0

@532910
Copy link
Author

532910 commented Jan 2, 2019

not fixed in 2.1.0

@532910
Copy link
Author

532910 commented Jan 2, 2019

img_20190102_052916

@tobexyz
Copy link
Owner

tobexyz commented Jan 2, 2019

ok, I see... I'll take a look at it. thx.

tobexyz added a commit that referenced this issue Jan 5, 2019
@tobexyz
issue #7 adaptive icon shape
48ae175
@tobexyz
Copy link
Owner

tobexyz commented Jan 5, 2019

should be fixed in version 2.1.1

@532910
Copy link
Author

532910 commented Jan 9, 2019

Yes, it's fixed in 2.1.1. Thank you!

@532910 532910 closed this as completed Jan 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
2.1.0
Development

No branches or pull requests
2 participants
@532910 @tobexyz