nil pointer is also considered an empty map. #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobgu
reviewed
Jan 5, 2018
| return zeroValue, false | ||
| } | ||
|
|
||
| // Store returns a new {{.MapTypeName}} containing value identified by key. | ||
| func (m *{{.MapTypeName}}) Store(key {{.MapKeyTypeName}}, value {{.MapValueTypeName}}) *{{.MapTypeName}} { | ||
| if m == nil { |
There was a problem hiding this comment.
A regular Go map would panic in this case. Do you think it makes sense to implicitly create a new map here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found it awkward to have to do New*Map before actually using them. With these pretty small changes you can just e.g. var m FooBarMap and play with it directly.
Similar changes to vectors/sets would be nice too, but I did not need them and due to performance reasons I think I am refactoring my design away from this; golang gc is stupidly expensive so these datastructures wind up being much slower than I thought. Live and learn :-)