Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search whole inheritance hierarchy for invariants #107

Merged
merged 3 commits into from May 30, 2017
Merged

Search whole inheritance hierarchy for invariants #107

merged 3 commits into from May 30, 2017

Conversation

exarkun
Copy link
Contributor

@exarkun exarkun commented May 26, 2017

Fixes #106

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 98.547% when pulling 9031286 on LeastAuthority:106.distant-invariants into decc5bb on tobgu:master.

tobgu
tobgu requested changes May 26, 2017
View reviewed changes
Copy link
Owner

@tobgu tobgu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor comment, apart from that it looks good to me. Thanks!

tests/class_test.py Outdated

try:
MultipleInvariantGlobal(distant=False, nearby=False)
except InvariantException as e:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just put an assert False here as well

@exarkun
Copy link
Contributor Author

exarkun commented May 29, 2017

Just one minor comment, apart from that it looks good to me. Thanks!

Ah yes, good catch, thanks. Should be addressed now.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 98.547% when pulling f27417e on LeastAuthority:106.distant-invariants into decc5bb on tobgu:master.

@tobgu tobgu merged commit 90ae3ae into tobgu:master May 30, 2017
@tobgu
Copy link
Owner

tobgu commented May 30, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobgu tobgu tobgu requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@exarkun @coveralls @tobgu