[modules/playerctl]: use playerctl -f and add playerctl.args
#793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…args` 1. Use `playerctl -f` to format, which is more powerful. This also fixes tobi-wan-kenobi#767, which is caused by missing a few fields of the metadata. 2. Add `playerctl.args`, so that users can choose a specific player, etc. 3. Display nothing when there's no running player. This is a breaking change. Users need to change `{title}` to `{{title}}`.
ouuan
changed the title
playerctl -f and add playerctl.argsplayerctl -f and add playerctl.args
|
Looks good to me! I think the best option is to just break it. The change to parameters will be noted in the changelog for a future release. Plus users who didn't notice the change will notice it when the module doesn't work after the update. |
I am grateful for that vote of confidence, now I just need to jot that down so I don't forget :P I agree, I would also just go ahead and break the interface. If somebody complains, we can always re-introduce a compatibility layer. But generally, I would like to avoid code growth because we try to stay backwards compatible always. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
playerctl -fto format, which is more powerful. This also fixes playerctl not displaying all information #767, which is caused by missing a few fields of the metadata.playerctl.args, so that users can choose a specific player, etc.This is a breaking change. Users need to change
{title}to{{title}}.I'm not sure how should I handle a breaking change. Should I add a new parameter like
playerctl.playerctl_format, or replace{artist}with{{artist}}, or just break it?