Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silence exceptions in the spotify module #840

Conversation

LokiLuciferase
Copy link
Contributor

In reference to: #839

@tobi-wan-kenobi
Copy link
Owner

tobi-wan-kenobi commented Dec 28, 2021

I think the except block might require a "pass" now, since it's empty (?)

But as it works for you, I will go ahead and merge as is.

Many thanks for your contribution!

Edit: Typo

@tobi-wan-kenobi tobi-wan-kenobi merged commit 4b7a6a1 into tobi-wan-kenobi:main Dec 28, 2021
@LokiLuciferase
Copy link
Contributor Author

LokiLuciferase commented Dec 28, 2021

I think the except block might require a "pass" now, since it's empty (?)

The except block still assigns the song string to be '', so that should be fine as is (though I just realized that the github app doesn't seem to render the indentation correctly in the changed file view, so that may have been the source of confusion...).

Thanks for the quick response!

@LokiLuciferase LokiLuciferase deleted the feature/silence-spotify-exceptions branch December 28, 2021 11:21
@tobi-wan-kenobi
Copy link
Owner

though I just realized that the github app doesn't seem to render the indentation correctly in the changed file view

That was the issue exactly...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants