style: further tidying employing go doc 1.19+ spec and features #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
|
Looks tidy! Thank you! Feel free to fix the remaining linter issues in another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did a quick pass to ensure the doc comments conform to go doc spec, and reworded some for clarity (using 1.19 features since you bumped the version). Thanks again for the link.
I do have a couple actual features in mind I'd like to try my hand at implementing and submitting if I can, not just endless obsessing over comment style, I promise. 😄 I just like to get all the styling stuff out of the way first when I find a project to contribute to, otherwise it tends to be quite a nuisance to keep those tweaks from slipping into unrelated feature commits if I get to that point.