-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
starting point for scss or sass #36
starting point for scss or sass #36
Conversation
@nmccready Thanks for starting this discussion 🐝 I'm a bit torn. I see SpinKit more as a sandbox from which you can grab some CSS and customize it for your site, not a framework. I'm not sure how well this aligns with that, and if the added complexity here adds enough value. What are your thoughts? |
Cool, I am not really trying to force a framework here. I am just trying to make it easily importable CSS or SASS. |
Ideally this would be nice if you could import the css via some framework like bower but for css 😄 |
I love this idea. Would be nice if some of the properties could be changed with SCSS-variables. |
I think it'd be great to drop in via SASS/SCSS. @tobiasahlin I know what you mean with reference to a Sandbox. But I think people love this a bit too much now :) Maybe having a separate project to the 'sandbox' version? |
This is true. All ✨ for this part. @paulrose @nmccready Let's make it happen. @jmagnusson |
@tobiasahlin if you look at my code you'll see that I've added:
Sure we can go with this PR instead, but like it says it's a starting point whilst #50 is basically good to merge and put in production. |
As suggested in #57 this may be a candidate for a gulp project. So simply compile templates down to css and scss. |
@tobiasahlin Let me know how you want to proceed . |
Any thought on less. I can contribute the code also. |
@nmccready Closing this since @jmagnusson had already come really far with his PR (I totally missed that before), adding gulp as well (#62). As soon as that lands we can start polishing that implementation ✨ |
First of all this spinner kit is awesome and I want to thank you very much.
This is a subset of spinners that I have combined into a single scss file which has been tested and is in full use at my company. This is intended as a starting file to work towards so that the css can be compiled down to a dist/spin-kit.css as the end goal.
Therefore, this is not meant to be a finished peace but is intended as a starting point as a discussion on how you want to proceed. I am fully open to adding a build framework to compile this scss down for you so it can be in separate encapsulated files like wave.scss, and three-bounce.scss. Personally I would favor npm/Grunt or Rails but it is up to you.
I'd love to help contribute.