Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

package.json breaks npm import with Browserify #96

Closed
strom opened this issue Aug 13, 2015 · 1 comment · Fixed by #143
Closed

package.json breaks npm import with Browserify #96

strom opened this issue Aug 13, 2015 · 1 comment · Fixed by #143

Comments

@strom
Copy link

strom commented Aug 13, 2015

The current main is the gulpfile. However, there are dependencies specified as devDependencies, which breaks Browserify's bundle function because it can't find modules that are required.

I believe the solution should be to remove gulpfile.js as the main file in package.json, because users aren't going to use the gulpfile from this project outside of developing.
@tobiasahlin
Copy link
Owner

@strom Thanks for reporting! 🙇❤️

I believe the solution should be to remove gulpfile.js as the main file in package.json, because users aren't going to use the gulpfile from this project outside of developing.

Sounds fair. @jmagnusson thoughts?

@thinkallabout thinkallabout mentioned this issue Oct 2, 2016
Closed
@tobiasahlin tobiasahlin mentioned this issue Oct 27, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

v2 tobiasahlin/SpinKit
2 participants
@strom @tobiasahlin