-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v2 #143
v2 #143
Conversation
@tobiasahlin You are right in a sense that there's nothing to build as no preprocessors are present anymore, but don't you want to maybe have a very minimalistic npm script (or something) way of generating the minified CSS? I can imageine re-generating this file manually can be tedious. |
@wolfika Possibly, let's evaluate and see 🙏 as long as the build process is literally one single to minimize the CSS (like it is now), I don't think it's too bad. Let's see! |
This PR puts SpinKit on v2.0.0. It reworks a few of the spinners, adds a new one, removes all dependencies, and moves away from SCSS in favor of using CSS variables for all configurations.
Changelog
inline-block
is no longed used to position any spinners (decoupling spacing from any potential font effects).Fixes
flexbox
rather thaninline-block
for positioning.