Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2 #143

Merged
merged 38 commits into from
Oct 28, 2019
Merged

v2 #143

merged 38 commits into from
Oct 28, 2019

Conversation

tobiasahlin
Copy link
Owner

@tobiasahlin tobiasahlin commented Oct 27, 2019

This PR puts SpinKit on v2.0.0. It reworks a few of the spinners, adds a new one, removes all dependencies, and moves away from SCSS in favor of using CSS variables for all configurations.

Changelog

  • New: Added examples.html, with an overview of all spinners
  • New: Added a brand new chase spinner
  • New: Added spinkit.min.css
  • Fixed: inline-block is no longed used to position any spinners (decoupling spacing from any potential font effects).
  • Changed: Most spinners now have more distinct and shorter names.
  • Changed: No positioning is now applied by default on any of the spinners.
  • Changed: All elements now only have one single class.
  • Changed: No more dependencies. gulp, npm, node, etc. is not required to build this project. There's nothing to build.
  • Changed: No more SCSS. All configuration is now done through CSS vars.
  • Fixed: All keyframe animations are now named after the elements/classes that are using them.

Fixes

@tobiasahlin
Copy link
Owner Author

Preview of new chase spinner:

chase

@tobiasahlin tobiasahlin changed the title [WIP] V2, Lean v2 Oct 28, 2019
@wolfika
Copy link

wolfika commented Oct 28, 2019

Changed: No more dependencies. gulp, npm, node, etc. is not required to build this project. There's nothing to build.

@tobiasahlin You are right in a sense that there's nothing to build as no preprocessors are present anymore, but don't you want to maybe have a very minimalistic npm script (or something) way of generating the minified CSS? I can imageine re-generating this file manually can be tedious.

@tobiasahlin
Copy link
Owner Author

@wolfika Possibly, let's evaluate and see 🙏 as long as the build process is literally one single to minimize the CSS (like it is now), I don't think it's too bad. Let's see!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants