Give priority to href over edDraft in reverse lookup #452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for tobie#450. Code that populated the reverse lookup table seemed to be willing to give priority to `href` over `edDraft`, but it had 2 bugs: 1. it checked for `edDraft` in the properties of the output object not to override a previous entry, but the entry that is inserted is `normalizeUrl(edDraft)`, not `edDraft` 2. it did not add all `href` entries before looking at `edDraft`. New test that makes sure that the returned ref is always the one that matches `href` if there is one added.
|
Good catch! Thanks a bunch. And thanks for the tests! A new version of Specref updated with these changes should auto-deploy within minutes. You can search www.specref.org to check for it. Don't hesitate to comment back here if you can't find your changes within 10 minutes; it's a sign something is off and I'll immediately look into it. Thanks! Specref loosely follows the process described in The Pull Request Hack. You've thus been granted commit access to the repo. Please read-up on how to make manual changes, get non-trivial changes reviewed by someone (I'm sure you'll be a good judge of when that's necessary) and feel free to ask if something's unclear. Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #450.
Code that populated the reverse lookup table seemed to be willing to give priority to
hrefoveredDraft, but it had 2 bugs:edDraftin the properties of the output object not to override a previous entry, but the entry that is inserted isnormalizeUrl(edDraft), notedDrafthrefentries before looking atedDraft.New test that makes sure that the returned ref is always the one that matches
hrefif there is one added.