Adding support for ONE Browser

tobie · Jan 30, 2013 · cb54949 · cb54949
1 parent 190297b
commit cb54949
Show file tree

Hide file tree

Showing 4 changed files with 35 additions and 0 deletions.
diff --git a/regexes.yaml b/regexes.yaml
@@ -277,6 +277,9 @@ user_agent_parsers:
     family_replacement: 'Mobile Safari'
 
   - regex: '(AvantGo) (\d+).(\d+)'
+
+  - regex: '(OneBrowser)/(\d+).(\d+)'
+    family_replacement: 'ONE Browser'
 
   - regex: '(Avant)'
     v1_replacement: '1'

diff --git a/test_resources/test_device.yaml b/test_resources/test_device.yaml
@@ -120,6 +120,9 @@ test_cases:
   - user_agent_string: 'Mozilla/5.0 (Symbian/3; Series60/5.3 Nokia701/111.020.0307; Profile/MIDP-2.1 Configuration/CLDC-1.1 ) AppleWebKit/533.4 (KHTML, like Gecko) NokiaBrowser/7.4.1.14 Mobile Safari/533.4 3gpp-gba'
     family: 'Nokia 701'
 
+  - user_agent_string: 'OneBrowser/3.0 (NokiaC2-00/03.42)'
+    family: 'Nokia C2-00'
+
   - user_agent_string: 'Mozilla/5.0 (Series40; NokiaC2-03/07.48; Profile/MIDP-2.1 Configuration/CLDC-1.1) Gecko/20100401 S40OviBrowser/2.2.0.0.33'
     family: 'Nokia C2-03'
 
@@ -201,6 +204,9 @@ test_cases:
   - user_agent_string: 'SAMSUNG-C3053/1.0 Openwave/6.2.3 Profile/MIDP-2.0 Configuration/CLDC-1.1 UP.Browser/6.2.3.3.c.1.101 (GUI) MMP/2.0'
     family: 'Samsung C3053'
 
+  - user_agent_string: 'OneBrowser/3.0 (SAMSUNG-GT-S5253/S5253DDKJ2)'
+    family: 'Samsung GT-S5253'
+
   - user_agent_string: 'Mozilla/3.0 (Planetweb/2.100 JS SSL US; Dreamcast US)'
     family: 'Sega Dreamcast'
 

diff --git a/test_resources/test_user_agent_parser.yaml b/test_resources/test_user_agent_parser.yaml
@@ -502,6 +502,18 @@ test_cases:
     minor:
     patch:
 
+  - user_agent_string: 'OneBrowser/3.0 (SAMSUNG-GT-S5253/S5253DDKJ2)'
+    family: 'ONE Browser'
+    major: '3'
+    minor: '0'
+    patch:
+
+  - user_agent_string: 'OneBrowser/3.0 (NokiaC2-00/03.42)'
+    family: 'ONE Browser'
+    major: '3'
+    minor: '0'
+    patch:
+
   - user_agent_string: 'SAMSUNG-C3053/1.0 Openwave/6.2.3 Profile/MIDP-2.0 Configuration/CLDC-1.1 UP.Browser/6.2.3.3.c.1.101 (GUI) MMP/2.0'
     family: 'Openwave'
     major: '6'

diff --git a/test_resources/test_user_agent_parser_os.yaml b/test_resources/test_user_agent_parser_os.yaml
@@ -497,6 +497,20 @@ test_cases:
     patch:
     patch_minor:
 
+  - user_agent_string: 'OneBrowser/3.0 (SAMSUNG-GT-S5253/S5253DDKJ2)'
+    family: 'Other'
+    major:
+    minor:
+    patch:
+    patch_minor:
+
+  - user_agent_string: 'OneBrowser/3.0 (NokiaC2-00/03.42)'
+    family: 'Other'
+    major:
+    minor:
+    patch:
+    patch_minor:
+
   - user_agent_string: 'Huawei/1.0/0HuaweiG2800/WAP2.0/Obigo-Browser/Q03C MMS/Obigo-MMS/1.2'
     family: 'Other'
     major: