This repository has been archived by the owner on Jul 19, 2018. It is now read-only.
python packaging #28
Merged
python packaging #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
skliffmueller
pushed a commit
to skliffmueller/ua-parser
that referenced
this pull request
Oct 22, 2015
python packaging
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I implemented proper python packaging. I'd love to discuss this to see if you're interested in merging in the changes, and potentially submitting this code to PyPI so that other projects can install this ua_parser module simply by adding it to their REQUIREMENTS file.
Thanks for your work on this project. We just discovered it here at PBS and really are excited to start using it.