Device Brand & Model (Pig and Java)

[nielsbasjes]

I created a Java and Pig implementation that supports the device brand and model additions.
I based these on the latest branch by @commenthol (Pull request #285)

In this form the unit tests for Java will fail with

     unacceptable character '�' (0xFFFD) special characters are not allowed

This is caused by several lines in the test_resources/test_device.yaml that contain those characters.
I have not fixed this in these commits because I do not know what the correct solution is for these cases.

Steve Jiang (@sjiang): Please validate this implementation as you are the java maintainer.

[Ironholds]

@sjiang comments/assists? Otherwise I'll probably have to just close this off (bug in the patch nobody here knows how to fix + substantially out of date).

[nielsbasjes]

I wrote this patch long ago. I have no idea why it has not been integrated yet. I see there is now a merge conflict which I could revolve. But if a patch for a part where I am the maintainer never gets merged then can't maintain anything. So what do we do now?

[Ironholds]

Rebase it and solve for the conflict, and I'll trust you to know what you're doing around the pig setup. Solved :).

[nielsbasjes]

Yes, but if it then again does not get pulled in, it will have been useless
work ... again.
There hasn't been any activity on this project for ages.

On Sun, Aug 24, 2014 at 12:25 AM, Oliver Keyes notifications@github.com
wrote:

Rebase it and solve for the conflict, and I'll trust you to know what
you're doing around the pig setup. Solved :).

—
Reply to this email directly or view it on GitHub
#320 (comment).

Best regards / Met vriendelijke groeten,

Niels Basjes

[Ironholds]

@nielsbasjes Yeah, not since the set of patches we merged, ooh, last week ;p.

Yes, historically it's been a struggle for collaborators to find the time to merge patches and do work. We solved for this by adding more collaborators. Let me know if you're interested in rewriting and I'll merge if in if it passes the tests. Alternately, let me know if you're not interested in the timesink and I'll close it. Up to you.