Java Parser: Fixes issue #374 with OS $1 replacement

[commenthol]

This fixes the issue #374 within the java parser.

[somechris]

We're on a snapshot version anyways.
Why do we need to increase the version number?

[commenthol]

For your remarks on "*.contains("$1") please check:
https://github.com/tobie/ua-parser/blob/master/java/src/main/java/ua_parser/UserAgentParser.java#L94
as well as
https://github.com/tobie/ua-parser/blob/master/java/src/main/java/ua_parser/DeviceParser.java#L88
I think there is a reason to keep this.
If I might be wrong, please issue a PR.
With regards to the versioning I changed to the release version 1.3.0.

[somechris]

I changed to the release version 1.3.0.

The java part already has seen a version 1.3.0 (see 7239f0b).

If you think a separate release for the java version is needed, I'd split that out to separate
commits, followed by a "bump to SNAPSHOT" commit as was done with previous releases:

• 1.3.0 -> 7239f0b
• 1.2.2 -> 5e4a38e

But is this tiny change worth a version change at all?

[commenthol]

Is any change worth a version change? Please tell me what you want me to do.
A simple "Stay on version 1.3.0-SNAPSHOT" would do.

[somechris]

I have no say here, but yes: staying on version 1.3.0-SNAPSHOT would make most sense to me.

[commenthol]

Sorry for this. Now it should have the right version.

[somechris]

Looks good to me now. Verified that tests now pass.

(My inline comments are only nits anyways)

[rbywater]

In terms of version I'd actually suggest it should 1.4.0-SNAPSHOT. According to the Git log, the version in the pom went to 1.3 and then back to 1.3-SNAPSHOT. There's also a tag already for java-1.3.0 so it would seem safest to bump the version up to avoid any issues where people have already picked up 1.3.0 as being "official".

[somechris]

According to the Git log, the version in the pom went to 1.3 and then back to 1.3-SNAPSHOT

Yes, and ua-parser has always put the SNAPSHOT version after the release:

• 1.2.2
• 1.2.2-SNAPSHOT
• 1.3.0
• 1.3.0-SNAPSHOT

ua-parsers approach may be unusual to some, but (as no release plugin etc is in place) it's
not a problem either. Maven can cope with that just fine.

Trading the x -> x-SNAPSHOT -> (x+1) -> (x+1)-SNAPSHOT scheme for
x-SNAPSHOT -> x -> (x+1)-SNAPSHOT -> (x+1) sounds good, but versioning is
unrelated to issue #374 that this pull request covers.
So I'd put version changes in a separate pull request.

[somechris]

So I'd put version changes in a separate pull request.

I've done so in pull request #380

[rbywater]

Yes sorry - didn't mean to hijack the pull request! Thanks for putting in #380 - saves me jumping in to do the same.

[Ironholds]

#434 I believe handles the same thing.