Skip to content
This repository has been archived by the owner on Apr 28, 2022. It is now read-only.

new settings #270

Closed
wants to merge 1 commit into from
Closed

new settings #270

wants to merge 1 commit into from

Conversation

MrTheBarbarian
Copy link

  • added static IP configuration
  • added WiFi portal time out

- added static IP configuration
- added WiFi portal time out
@toblum toblum requested a review from debsahu November 30, 2018 21:57
@toblum
Copy link
Owner

toblum commented Nov 30, 2018

@MrTheBarbarian Thank you for your contribution. We'll test it out.

@debsahu
Copy link
Collaborator

debsahu commented Nov 30, 2018

We already have this in the current code (here and here), not in definitions.h. @toblum cant users just comment/uncomment here?

   // Uncomment if you want to restart ESP8266 if it cannot connect to WiFi.
   // Value in brackets is in seconds that WiFiManager waits until restart
   //wifiManager.setConfigPortalTimeout(180);
 
   // Uncomment if you want to set static IP 
   // Order is: IP, Gateway and Subnet 
   //wifiManager.setSTAStaticIPConfig(IPAddress(192,168,0,128), IPAddress(192,168,0,1), IPAddress(255,255,255,0));   

@dermalikmann
Copy link
Collaborator

dermalikmann commented Dec 3, 2018

If it is ok that I throw my humble opinion in here:
I would prefer changing the static IP in definitions.h like @MrTheBarbarian did, instead of changing it in the McLighting.ino.

debsahu added a commit that referenced this pull request Dec 3, 2018
* Contributions by @	MrTheBarbarian from #270 Putting Static IP config added in Jun 17th 2018 to definitions.h
* rethink ESP.getChipId implementaion
* check ArduinoJSON version
* Try restting prevmode as suggested in #276
@debsahu debsahu mentioned this pull request Dec 3, 2018
@debsahu
Copy link
Collaborator

debsahu commented Dec 3, 2018

I have incorporated all the changes by @MrTheBarbarian in #279, Thank you so much for contributing!

@debsahu debsahu closed this Dec 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants