Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for FramedBlocks #5

Closed
TobsenD opened this issue Aug 30, 2023 · 2 comments
Closed

Add Support for FramedBlocks #5

TobsenD opened this issue Aug 30, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@TobsenD
Copy link
Owner

TobsenD commented Aug 30, 2023

As requested we should also support Framed Blocks.
See comment in #4

XFactHD/FramedBlocks#299

@TobsenD TobsenD added the enhancement New feature or request label Aug 30, 2023
@TobsenD TobsenD self-assigned this Aug 30, 2023
@XFactHD
Copy link

XFactHD commented Aug 30, 2023

FramedBlocks dev here, the request on #4 to make the XTones blocks have a BlockEntity to be compatible with FramedBlocks is a misunderstanding. The reason the Glaxx block specifically does not work is that it's a non-solid block (like vanilla glass) and those blocks don't allow me to programmatically make sure they are actually full cubes. For that reason, these blocks must be tagged with the framedblocks:frameable block tag. This tag already includes a few important vanilla and Forge tags, including forge:glass, but since Glaxx is not tagged as glass it is not picked up by default. The fix would be to either tag Glaxx as forge:glass if it makes sense to categorize it as such or otherwise tag it as framedblocks:frameable directly.

@TobsenD
Copy link
Owner Author

TobsenD commented Aug 30, 2023

Thanks for the info. This is exactly what i had taken from your comment in the ticket on your side and also wanted to try first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants