Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global play/pause makes the game play an audio file? #428

Closed
Nchi opened this issue Jul 8, 2020 · 4 comments
Closed

Global play/pause makes the game play an audio file? #428

Nchi opened this issue Jul 8, 2020 · 4 comments

Comments

@Nchi
Copy link

Nchi commented Jul 8, 2020

Why?? I would half understand if it unmuted the game, but it doesn't! It plays while the game is muted.... Either way you probably shouldn't touch global music controls- it sorta defeats the point, especially when I can just mute right there

@Nchi Nchi changed the title Global play/pause makes the game play an audio file?? Global play/pause makes the game play an audio file? Jul 9, 2020
@tobspr
Copy link
Member

tobspr commented Jul 18, 2020

It's a windows issue. Can't do anything about that

@tobspr tobspr closed this as completed Jul 18, 2020
@Nchi
Copy link
Author

Nchi commented Jul 18, 2020

Aren't you using electron/chrome/chromium? chrome://flags/#hardware-media-key-handling can be passed in index I think,

app.commandLine.appendSwitch('disable-features', 'HardwareMediaKeyHandling,MediaSessionService');

from electron/electron#18253 (comment)

found it here
electron/electron#21731

<3 You probably dont want me to actually PR, I might be able to research but... no real coding yet- might have to start if you say its another windows bug :)

(OS bugs are to be worked around, not stopped at!)

@dengr1065
Copy link
Collaborator

that's clearly not a windows bug, same happens on all platforms, but imo it's useful

@Nchi
Copy link
Author

Nchi commented Jul 18, 2020

If it didnt overlap the existing music maybe- but what is ever the point of double music lol

and yea I almost got a linux box up to test, but then read globals tend to break from dbus so... yea. also a linux vm lol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants