Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in Erin Bruneton copy_inscatter.glsl code #85

Closed
GarryGuanDoubleG opened this issue Sep 27, 2017 · 2 comments
Closed

Error in Erin Bruneton copy_inscatter.glsl code #85

GarryGuanDoubleG opened this issue Sep 27, 2017 · 2 comments
Assignees

Comments

@GarryGuanDoubleG
Copy link

https://github.com/tobspr/RenderPipeline/blob/master/rpplugins/scattering/shader/eric_bruneton/copy_inscatter.compute.glsl

line 42: vec3 mie = texelFetch(deltaSRSampler, ivec3(coord, layer), 0).xyz;
should be vec3 mie = texelFetch(deltaSMSampler, ivec3(coord, layer), 0).xyz;

@tobspr
Copy link
Owner

tobspr commented Sep 28, 2017

Nice catch! Have you checked if this changes the rendering result?

@tobspr tobspr self-assigned this Sep 28, 2017
@GarryGuanDoubleG
Copy link
Author

It changes the intensity of the mie factor when the sun is setting. It's a lot more yellow & intense around the horizon just under the sun and the overall yellow area around the sun fades faster than if it were set to the deltaSRSampler. The sun disk is also more visible.

@tobspr tobspr closed this as completed in ec6d76e Nov 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants