Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mac support #147

Closed
JaccoGoris opened this issue Jun 13, 2020 · 14 comments
Closed

Mac support #147

JaccoGoris opened this issue Jun 13, 2020 · 14 comments

Comments

@JaccoGoris
Copy link

Hi Tobias,
First off, really cool stuff!

Secondly, I saw the Linux thread, but didn't want to re-open that one for this (I don't know which you prefer but this seams more clean)

Is it difficult to create a mac version for steam? I can help out potentially (Frontend and iOS developer)
I checked in on discord and saw that there is also other demand for this. So maybe we can put our head together to setup the pipe to generate mac builds too. So I can actually play it :D

@tobspr
Copy link
Member

tobspr commented Jun 13, 2020

The issue here is signing the apps - I don't have a mac available right now and I can't do that on windows :)

@JaccoGoris
Copy link
Author

https://www.electronjs.org/docs/tutorial/code-signing
I think we can work around this by using electron-forge or electron-builder to do it on CI, so you don't need a mac :)

@miguelslemos
Copy link

Yep, https://www.bitrise.io/pricing is free for open source. I could help to setup CI/CD environment too

@tobspr
Copy link
Member

tobspr commented Jun 21, 2020

@miguelslemos would be nice! Feel free to make a PR and let me know what you'd need from me :)

@tobspr tobspr added the on hold label Jun 21, 2020
@skandragon
Copy link

I'm happy to test and perhaps help. I do have a mac, and a signing key, and could probably work out other arrangements to make signing work.

@lafelong
Copy link

I think I've almost got a standalone build going on the Mac following the build instructions... but it fails with git errors?

Running yarn gulp from inside the gulp directory:
`Mac-Pro:gulp lafe$ yarn gulp
yarn run v1.22.4
$ gulp
Please set SHAPEZ_CLI_SERVER_HOST
Please set SHAPEZ_CLI_STAGING_FTP_USER
Please set SHAPEZ_CLI_STAGING_FTP_PW
Please set SHAPEZ_CLI_LIVE_FTP_USER
Please set SHAPEZ_CLI_LIVE_FTP_PW
fatal: Not a git repository (or any of the parent directories): .git
Error: Command failed: git rev-parse --short HEAD
fatal: Not a git repository (or any of the parent directories): .git

at checkExecSyncError (child_process.js:630:11)
at execSync (child_process.js:666:15)
at Object.getRevision (/Applications/shapez.io-master/gulp/buildutils.js:9:28)
at Object.gulptasksCSS (/Applications/shapez.io-master/gulp/css.js:6:35)
at Object.<anonymous> (/Applications/shapez.io-master/gulp/gulpfile.js:61:5)
at Module._compile (internal/modules/cjs/loader.js:1138:30)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:1158:10)
at Module.load (internal/modules/cjs/loader.js:986:32)
at Function.Module._load (internal/modules/cjs/loader.js:879:14)
at Module.require (internal/modules/cjs/loader.js:1026:19) {

status: 128,
signal: null,
output: [
null,
,
<Buffer 66 61 74 61 6c 3a 20 4e 6f 74 20 61 20 67 69 74 20 72 65 70 6f 73 69 74 6f 72 79 20 28 6f 72 20 61 6e 79 20 6f 66 20 74 68 65 20 70 61 72 65 6e 74 20 ... 19 more bytes>
],
pid: 19648,
stdout: ,
stderr: <Buffer 66 61 74 61 6c 3a 20 4e 6f 74 20 61 20 67 69 74 20 72 65 70 6f 73 69 74 6f 72 79 20 28 6f 72 20 61 6e 79 20 6f 66 20 74 68 65 20 70 61 72 65 6e 74 20 ... 19 more bytes>
}
error Command failed with exit code 1.`

@tobspr
Copy link
Member

tobspr commented Jun 24, 2020

Did you init it from git? Or did you just download a zip?

@lafelong
Copy link

lafelong commented Jun 25, 2020

Did you init it from git? Or did you just download a zip?

Ah... just downloaded the zip. That would probly explain the missing directories.
I'll reinstall git desktop and give it a try.

EDIT: Successfully built and running fine on Mac OS X 10.11.6 in Firefox 67, Opera 69, and Brave Version 1.10.97 Chromium: 83.0.4103.116 (Official Build) (64-bit)

@fresnik
Copy link

fresnik commented Jun 30, 2020

Hey, just wanted to add that I have been playing the demo in a browser and just love the game, so I bought it, but I will definitely buy it again if there's a mac version on Steam. 😉

@martinhanzik
Copy link

martinhanzik commented Jul 4, 2020

Something like https://github.com/samuelmeuli/action-electron-builder could be used to do this all in Github.

EDIT: Actually just updating the packager configuration should be all that is necessary, along the lines of https://www.electronjs.org/docs/tutorial/code-signing#electron-packager but of course that needs to be done on a Mac, which then makes it even more important to just move the whole release process to GitHub Actions or another form of CI.

@tobspr
Copy link
Member

tobspr commented Jul 18, 2020

Mac support isn't planned in the near future. So closing this one. If somebody makes a PR which automatically makes a running mac build and puts it into an artifactory, we can talk about that

@tobspr tobspr closed this as completed Jul 18, 2020
@skossan
Copy link

skossan commented Jan 23, 2022

Hey! Would love to know the status on this? Mac version would be great!

@tobspr
Copy link
Member

tobspr commented Apr 13, 2022

MacOS is now supported: https://store.steampowered.com/news/app/1318690/view/3178987160554616924

@fresnik
Copy link

fresnik commented Apr 13, 2022

MacOS is now supported

Great work! Just bought it again - thanks for the continued support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants