Skip to content

Commit

Permalink
fix(lint): dependency issue with eslint
Browse files Browse the repository at this point in the history
release-npm
  • Loading branch information
tobua committed Feb 14, 2024
1 parent 43174bd commit 5adcc1b
Show file tree
Hide file tree
Showing 3 changed files with 25 additions and 24 deletions.
7 changes: 4 additions & 3 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
id-token: write # npm provenance
contents: write # Create GitHub release and tag
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- name: 🗄️ Configure Cache
id: cache-dependencies
uses: actions/cache@v3
Expand All @@ -21,9 +21,10 @@ jobs:
- name: 📁 Install Dependencies
if: steps.cache-dependencies.outputs.cache-hit != 'true'
run: npm install
- name: 🧹 Lint
run: npm run lint
- name: 🧪 Test
run: npm test
- run: npm install -g npm@latest
- uses: tobua/release-npm-action@v2
- uses: tobua/release-npm-action@v3
with:
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
7 changes: 2 additions & 5 deletions configuration/eslint.cjs
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,7 @@ const customRules = {
// Allow assignment to function param properties, like parameter.innerHTML = ...
'no-param-reassign': [2, { props: false }],
// Any dependency can be imported, devDependencies however will be bundled if imported.
'import/no-extraneous-dependencies': [
2,
{ devDependencies: true, peerDependencies: true },
],
'import/no-extraneous-dependencies': [2, { devDependencies: true, peerDependencies: true }],
}

const customSettings = {
Expand Down Expand Up @@ -75,7 +72,7 @@ module.exports = {
{
// TypeScript
files: ['**/*.ts', '**/*.tsx'],
extends: ['airbnb-typescript', 'prettier'],
extends: ['airbnb', 'airbnb-typescript', 'prettier'],
rules: customRules,
settings: customSettings,
parser: '@typescript-eslint/parser',
Expand Down
35 changes: 19 additions & 16 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,36 +1,33 @@
{
"name": "padua",
"description": "Setup, configure, build and publish npm plugins.",
"version": "0.3.14",
"version": "0.0.0-development",
"repository": "github:tobua/padua",
"license": "MIT",
"author": "Matthias Giger",
"scripts": {
"lint": "eslint . --fix --ext .js,.jsx",
"lint-list": "DEBUG=eslint:cli-engine eslint . --fix --ext .js,.jsx",
"postinstall": "node ./installation.js",
"test": "vitest run --dir test"
},
"dependencies": {
"@babel/eslint-parser": "^7.23.3",
"@babel/preset-env": "^7.23.8",
"@babel/eslint-parser": "^7.23.10",
"@babel/preset-env": "^7.23.9",
"@manypkg/find-root": "^2.2.1",
"@npmcli/map-workspaces": "^3.0.4",
"@types/jest": "^29.5.11",
"@typescript-eslint/eslint-plugin": "^6.19.1",
"@typescript-eslint/parser": "^6.19.1",
"@types/jest": "^29.5.12",
"@typescript-eslint/eslint-plugin": "^7.0.1",
"@typescript-eslint/parser": "^7.0.1",
"current-git-branch": "^1.1.0",
"deep-for-each": "^3.0.0",
"deepmerge": "^4.3.1",
"esbuild": "^0.19.11",
"esbuild": "^0.20.0",
"eslint": "^8.56.0",
"eslint-config-airbnb": "^19.0.4",
"eslint-config-airbnb-typescript": "^17.1.0",
"eslint-config-prettier": "^9.1.0",
"eslint-plugin-babel": "^5.3.1",
"eslint-plugin-cypress": "^2.15.1",
"eslint-plugin-import": "^2.29.1",
"eslint-plugin-jsx-a11y": "^6.8.0",
"eslint-plugin-react": "^7.33.2",
"eslint-plugin-react-hooks": "^4.6.0",
"fast-glob": "^3.3.2",
"filesize": "^10.1.0",
"gzip-size": "^7.0.0",
Expand All @@ -40,15 +37,15 @@
"lodash.set": "^4.3.2",
"lodash.unset": "^4.5.2",
"logua": "^3.0.3",
"npm-check-updates": "^16.14.12",
"npm-check-updates": "^16.14.15",
"pacote": "^17.0.6",
"pakag": "^3.1.1",
"parse-gitignore": "^2.0.0",
"prettier": "^3.2.4",
"prettier": "^3.2.5",
"skip-local-postinstall": "^2.0.4",
"standard-version": "^9.5.0",
"strip-ansi": "^7.1.0",
"stylelint": "^16.2.0",
"stylelint": "^16.2.1",
"stylelint-config-recommended": "^14.0.0",
"ts-jest": "^29.1.2",
"typescript": "^5.3.3"
Expand All @@ -59,7 +56,7 @@
"source": "index.js",
"devDependencies": {
"jest-fixture": "^4.1.0",
"vitest": "^1.2.1"
"vitest": "^1.2.2"
},
"files": [
"configuration",
Expand All @@ -72,10 +69,16 @@
"build",
"plugin"
],
"overrides": {
"@typescript-eslint/eslint-plugin": "^7.0.1",
"@typescript-eslint/parser": "^7.0.1"
},
"prettier": "./configuration/.prettierrc.json",
"eslintConfig": {
"extends": "./configuration/eslint.cjs",
"ignorePatterns": ["template"],
"rules": {
"no-console": "off",
"import/extensions": [
2,
"always"
Expand Down

0 comments on commit 5adcc1b

Please sign in to comment.