Skip to content

Commit

Permalink
fix(configuration): switch node LTS and allow bundling devDependencies
Browse files Browse the repository at this point in the history
release-npm
  • Loading branch information
tobua committed Sep 15, 2023
1 parent 4d91679 commit 7beeb08
Show file tree
Hide file tree
Showing 4 changed files with 21 additions and 16 deletions.
5 changes: 5 additions & 0 deletions configuration/eslint.cjs
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,11 @@ const customRules = {
'react/no-array-index-key': 0,
// Allow assignment to function param properties, like parameter.innerHTML = ...
'no-param-reassign': [2, { props: false }],
// Any dependency can be imported, devDependencies however will be bundled if imported.
'import/no-extraneous-dependencies': [
2,
{ dependencies: true, devDependencies: true, peerDependencies: true },
],
}

const customSettings = {
Expand Down
2 changes: 1 addition & 1 deletion configuration/package.js
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ const initial = () => {
extends: './node_modules/padua/configuration/eslint.cjs',
},
engines: {
node: '>= 16',
node: '>= 18',
},
}

Expand Down
28 changes: 14 additions & 14 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,18 +10,18 @@
"test": "vitest run --dir test"
},
"dependencies": {
"@babel/eslint-parser": "^7.22.10",
"@babel/preset-env": "^7.22.10",
"@babel/eslint-parser": "^7.22.15",
"@babel/preset-env": "^7.22.15",
"@manypkg/find-root": "^2.2.1",
"@npmcli/map-workspaces": "^3.0.4",
"@types/jest": "^29.5.3",
"@typescript-eslint/eslint-plugin": "^6.4.0",
"@typescript-eslint/parser": "^6.4.0",
"@types/jest": "^29.5.4",
"@typescript-eslint/eslint-plugin": "^6.7.0",
"@typescript-eslint/parser": "^6.7.0",
"current-git-branch": "^1.1.0",
"deep-for-each": "^3.0.0",
"deepmerge": "^4.3.1",
"esbuild": "^0.19.2",
"eslint": "^8.47.0",
"esbuild": "^0.19.3",
"eslint": "^8.49.0",
"eslint-config-airbnb": "^19.0.4",
"eslint-config-airbnb-typescript": "^17.1.0",
"eslint-config-prettier": "^9.0.0",
Expand All @@ -35,31 +35,31 @@
"filesize": "^10.0.12",
"gzip-size": "^7.0.0",
"is-ci": "^3.0.1",
"jest": "^29.6.2",
"jest": "^29.7.0",
"lodash.get": "^4.4.2",
"lodash.set": "^4.3.2",
"lodash.unset": "^4.5.2",
"logua": "^2.3.0",
"npm-check-updates": "^16.12.2",
"pacote": "^17.0.2",
"npm-check-updates": "^16.14.2",
"pacote": "^17.0.4",
"pakag": "^3.1.1",
"parse-gitignore": "^2.0.0",
"prettier": "^3.0.2",
"prettier": "^3.0.3",
"skip-local-postinstall": "^2.0.4",
"standard-version": "^9.5.0",
"strip-ansi": "^7.1.0",
"stylelint": "^15.10.3",
"stylelint-config-recommended": "^13.0.0",
"ts-jest": "^29.1.1",
"typescript": "^5.1.6"
"typescript": "^5.2.2"
},
"type": "module",
"main": "index.js",
"bin": "cli.js",
"source": "index.js",
"devDependencies": {
"jest-fixture": "^4.1.0",
"vitest": "^0.34.2"
"vitest": "^0.34.4"
},
"files": [
"configuration",
Expand All @@ -86,6 +86,6 @@
"provenance": true
},
"engines": {
"node": ">= 16"
"node": ">= 18"
}
}
2 changes: 1 addition & 1 deletion test/configuration.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ test('Updates old package json properties.', async () => {

pkg = readFile('package.json')

expect(pkg.engines.node).toEqual('>= 16')
expect(pkg.engines.node).toEqual('>= 18')
})

test('Does not override configuration changes made by user after initial installation.', async () => {
Expand Down

0 comments on commit 7beeb08

Please sign in to comment.