wip

toby1984 · Jun 21, 2024 · 42522f0 · 42522f0
1 parent 5d0db14
commit 42522f0
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 11 deletions.
diff --git a/common/src/main/java/de/codesourcery/versiontracker/common/ArtifactResponse.java b/common/src/main/java/de/codesourcery/versiontracker/common/ArtifactResponse.java
@@ -72,7 +72,7 @@ public static UpdateAvailable fromString(String s)
 
 	public Artifact artifact;
 	public Version currentVersion;
-	// TODO: Rename to 'latestReleasedVersion' version, snapshots are not considered
+	// TODO: This is actually the latest non-snapshot version that is not blacklisted by the client
 	public Version latestVersion;
 	public UpdateAvailable updateAvailable;
 

diff --git a/common/src/main/java/de/codesourcery/versiontracker/common/server/APIImpl.java b/common/src/main/java/de/codesourcery/versiontracker/common/server/APIImpl.java
@@ -358,16 +358,23 @@ public QueryResponse processQuery(QueryRequest request) throws InterruptedExcept
             if ( info.hasVersions() )
             {
                 if ( artifact.hasReleaseVersion() ) {
-                    // FIXME: Problem here is that versionTracker.getVersionInfo()
-                    //        will only retrieve the release dates for the *TRULY* latest release/snapshot versions
-                    //        (as according to the Maven Indexer XML file) as it doesn't know about any blacklists
-                    //        that a client is using.
-                    //        In this case, the release date of that specific version may very well not have been fetched
-                    //        and hence the enforcer rule can never perform an age comparison since the release date
-                    //        always stays unknown.
-                    //
-                    //        TODO: Trigger an MavenCentralProvider#update() call just with that version number
-
+                    /*
+                     *FIXME: Problem here is that versionTracker.getVersionInfo()
+                     *       will only retrieve the release dates for the *TRULY* latest release/snapshot versions
+                     *       (as given by the Maven Indexer XML file) as it doesn't know about any artifact blacklists
+                     *       a client may be using.
+                     *       In this case, the release date of that specific version may very well not have been fetched
+                     *       and hence the enforcer rule can never perform an age comparison since the release date
+                     *       always stays unknown.
+                     *
+                     *       TODO:
+                     *
+                     *      1.) Trigger a MavenCentralProvider#update() call just with that version number OR
+                     *          figure out how to fetch more version info per REST API call (with less attributes)
+                     *
+                     * In either case, the client should probably perform some kind of rate limiting so we don't
+                     * get banned because we're hammering the server.
+                     */
                     x.latestVersion = info.findLatestReleaseVersion( request.blacklist ).orElse( null );
                     if ( LOG.isDebugEnabled() ) {
                         LOG.debug("processQuery(): latest release version from metadata: "+info.latestReleaseVersion);