Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove raw SQL usage from the codebase #20

Open
tobyash86 opened this issue Jun 15, 2020 · 5 comments · Fixed by #24
Open

Remove raw SQL usage from the codebase #20

tobyash86 opened this issue Jun 15, 2020 · 5 comments · Fixed by #24
Assignees
@ma-rybak
Labels
bug Something isn't working

Comments

@tobyash86
Copy link
Owner

There are some raw SQL queries in the code. We should consider using EF Core instead.
For some reason EF does not work properly in the checkout, we need to find out why and fix it.
@tobyash86 tobyash86 added the bug Something isn't working label Jun 15, 2020
@tobyash86
Copy link
Owner Author

The issue causes an exception when two exactly the same products are added to the cart.

The bug exists due to the fact that we call SQL manually to populate tables during checkout. We generate SQL with the same keys twice for the same products.

@tobyash86 tobyash86 self-assigned this Jun 18, 2020
@tobyash86 tobyash86 added this to In progress in WebGoat-0.1 Jun 18, 2020
@tobyash86 tobyash86 added this to the webgoat.net-1.0 milestone Jun 18, 2020
@tobyash86 tobyash86 removed their assignment Jun 18, 2020
@tobyash86 tobyash86 moved this from In progress to To do in WebGoat-0.1 Jun 18, 2020
@tobyash86 tobyash86 self-assigned this Jun 18, 2020
@tobyash86 tobyash86 moved this from To do to In progress in WebGoat-0.1 Jun 18, 2020
@tobyash86 tobyash86 moved this from In progress to To do in WebGoat-0.1 Jun 18, 2020
@tobyash86 tobyash86 assigned tobyash86 and unassigned tobyash86 Jun 18, 2020
@tobyash86 tobyash86 moved this from To do to In progress in WebGoat-0.1 Jun 18, 2020
@tobyash86
Copy link
Owner Author

It seems like fixing the cart did not help with removing raw SQL. The main issue still exists.

ma-rybak added a commit that referenced this issue Nov 13, 2020
@ma-rybak
Bug #20: Remove raw SQL usage from the codebase
a99098c
ma-rybak added a commit that referenced this issue Nov 16, 2020
@ma-rybak
Bug #20: Invalid number of displayed featured products.
0295581
@tobyash86 tobyash86 linked a pull request Nov 17, 2020 that will close this issue
Issue 20: Remove raw SQL usage from the codebase #24
Merged
tobyash86 added a commit that referenced this issue Nov 17, 2020
@tobyash86
Merge pull request #25 from tobyash86/Bug-#20-Remove-raw-SQL-usage-fr…
99b7eb4 
…om-the-codebase

Bug #20: Remove raw SQL usage from the codebase
@tobyash86
Copy link
Owner Author

Fixed. Requires verification on dev branch.

ma-rybak added a commit that referenced this issue Nov 18, 2020
@ma-rybak
Reverting #20 - there were issues with 3 or more items in cart.
899be21
@ma-rybak
Copy link
Contributor

Reverted changes - there were issues with checking out with over 3 items in the cart.

@create-issue-branch
Copy link

Branch issue-20-Remove_raw_SQL_usage_from_the_codebase created!

@tobyash86 tobyash86 removed their assignment Nov 18, 2020
@tobyash86 tobyash86 removed this from In progress in WebGoat-0.1 Dec 2, 2020
@tobyash86 tobyash86 removed this from the webgoat.net-0.1 milestone Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ma-rybak ma-rybak

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue 20: Remove raw SQL usage from the codebase tobyash86/WebGoat.NET
2 participants
@tobyash86 @ma-rybak