Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENHANCEMENTS] Potential security issues #55

Closed
PassiveLemon opened this issue Aug 25, 2023 · 3 comments
Closed

[ENHANCEMENTS] Potential security issues #55

PassiveLemon opened this issue Aug 25, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@PassiveLemon
Copy link
Collaborator

After getting the image scanned in Dockerhub, this critical CVE showed up. It has to do with the satori/go.uuid module that is being used and should be replaced! gofrs/uuid appears to be a safe replacement but there are plenty of others so I'll leave this up to you since you are the developer of Zoraxy.
@PassiveLemon PassiveLemon added the enhancement New feature or request label Aug 25, 2023
@tobychui
Copy link
Owner

Thanks for the tips. I will be replacing all of the satori/go.uuid with google/uuid instead.

tobychui added a commit that referenced this issue Aug 27, 2023
@tobychui
Optimized memory usage and root routing
73ab9ca 
+ Added unset subdomain custom redirection feature #46
+ Optimized memory usage by space time tradeoff in geoip lookup to fix #52
+ Replaced all stori/go.uuid to google/uuid for security reasons #55
@PassiveLemon
Copy link
Collaborator Author

PassiveLemon commented Aug 27, 2023 •
edited

The scan also now shows that x/net 0.11.0 has a vulnerability that could allow for cross-site script attacks: https://scout.docker.com/vulnerabilities/id/CVE-2023-3978?utm_source=hub&utm_medium=ExternalLink. Updating to a newer version (0.13.0+) appears to be the best course of action as shown in https://pkg.go.dev/golang.org/x/net?tab=versions

I don't think the implications of this one are that worry-some because that would require a weirdly specific case scenario but I guess having minimal security exploits is a good thing

@PassiveLemon PassiveLemon changed the title [ENHANCEMENTS] satori/go.uuid critical security issue [ENHANCEMENTS] Potential security issues Aug 27, 2023
@tobychui
Copy link
Owner

Fixed in v2.6.6 (go.mod updated and replaced all satori uuid with google uuid module)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tobychui @PassiveLemon