Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Questions about regular expressions #6

Closed
bokutin opened this issue Apr 24, 2020 · 5 comments
Closed

Questions about regular expressions #6

bokutin opened this issue Apr 24, 2020 · 5 comments

Comments

@bokutin
Copy link

bokutin commented Apr 24, 2020

p5-exporter-tiny/lib/Exporter/Tiny.pm

Line 33 in 0c5cb5f

($name =~ m{\A/.+/[msixpodual]+\z}) ?

Is modifier required for regular expressions?

$name =~ m{\A/.+/[msixpodual]+\z}
or
$name =~ m{\A/.+/[msixpodual]*\z}
@tobyink
Copy link
Owner

tobyink commented Apr 24, 2020

Hmm, I think you're right. It should be a *

@tobyink
Copy link
Owner

tobyink commented Apr 24, 2020

Pushed a change to github. I'll release new version assuming it passes all checks on Travis.

@tobyink
Copy link
Owner

tobyink commented Apr 24, 2020

Looks good. I'll release a fix today, hopefully.

@tobyink
Copy link
Owner

tobyink commented Apr 24, 2020

Released https://metacpan.org/release/TOBYINK/Exporter-Tiny-1.002002

@tobyink tobyink closed this as completed Apr 24, 2020
@bokutin
Copy link
Author

bokutin commented Apr 25, 2020

Thank you for your quick response!

netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this issue Apr 26, 2020
(devel/p5-Exporter-Tiny) Updated to 1.002002
c990580 
1.002002        2020-04-24

 [ Bug Fixes ]
 - Bug in handling regexps in import lists; Exporter::Tiny allowed regexps
   like /foo/i but not /foo/. Having trailing flags is now optional!
   Tomohiro Hosaka++
   <tobyink/p5-exporter-tiny#6>
 - Tests would fail if `PERL5OPT=-Mfeature=:5.18` environment variable was
   set. This is because bareword `-default` was being interpreted as the
   Perl `default` keyword.
   zhumengu++
   <tobyink/p5-exporter-tiny#5>
clrpackages pushed a commit to clearlinux-pkgs/perl-Exporter-Tiny that referenced this issue Apr 29, 2020
@fenrus75 @clrpackages
[update to 1.002002] like /foo/i but not /foo/. Having trailing flags…
c379e6d 
… is now optional!

1.002002	2020-04-24

 [ Bug Fixes ]
 - Bug in handling regexps in import lists; Exporter::Tiny allowed regexps
   like /foo/i but not /foo/. Having trailing flags is now optional!
   Tomohiro Hosaka++
   <tobyink/p5-exporter-tiny#6>
 - Tests would fail if `PERL5OPT=-Mfeature=:5.18` environment variable was
   set. This is because bareword `-default` was being interpreted as the
   Perl `default` keyword.
   zhumengu++
   <tobyink/p5-exporter-tiny#5>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bokutin @tobyink