Skip to content

Commit

Permalink
Fix for RT#86233
Browse files Browse the repository at this point in the history
  • Loading branch information
tobyink committed Jun 18, 2013
1 parent 8e9bdd2 commit c6b6745
Show file tree
Hide file tree
Showing 2 changed files with 61 additions and 2 deletions.
4 changes: 2 additions & 2 deletions lib/Types/Standard.pm
Original file line number Diff line number Diff line change
Expand Up @@ -1216,11 +1216,11 @@ $lib->get_type("Dict")->{coercion_generator} = sub
my $all_inlinable = 1;
for my $tc (values %dict)
{
$all_inlinable = 0 if $tc->has_coercion && !$tc->can_be_inlined;
$all_inlinable = 0 if !$tc->can_be_inlined;
$all_inlinable = 0 if $tc->has_coercion && !$tc->coercion->can_be_inlined;
last if!$all_inlinable;
}

if ($all_inlinable)
{
$C->add_type_coercions($parent => Stringable {
Expand Down
59 changes: 59 additions & 0 deletions t/rt86233.t
Original file line number Diff line number Diff line change
@@ -0,0 +1,59 @@
=pod
=encoding utf-8
=head1 PURPOSE
Fix: "Cannot inline type constraint check" error with compile and Dict.
=head1 SEE ALSO
L<https://rt.cpan.org/Ticket/Display.html?id=86233>.
=head1 AUTHOR
Vyacheslav Matyukhin E<lt>mmcleric@cpan.orgE<gt>.
(Minor changes by Toby Inkster E<lt>tobyink@cpan.orgE<gt>.)
=head1 COPYRIGHT AND LICENCE
This software is copyright (c) 2013 by Vyacheslav Matyukhin.
This is free software; you can redistribute it and/or modify it under
the same terms as the Perl 5 programming language system itself.
=cut

use strict;
use warnings;

use Test::More;
use Test::Fatal;

BEGIN {
package Types;

use Type::Library
-base,
-declare => qw[ Login ];
use Type::Utils;
use Types::Standard qw[ Str ];

declare Login,
as Str,
where { /^\w+$/ };
};

use Type::Params qw[ compile ];
use Types::Standard qw[ Dict ];

my $type = Dict[login => Types::Login];

ok not( $type->can_be_inlined );

ok not( $type->coercion->can_be_inlined );

is(exception { compile($type) }, undef);

done_testing;

0 comments on commit c6b6745

Please sign in to comment.