carry through extra parameters when completing HalfOps #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parameterized type subs will receive one argument with their arguments, but may also get additional arguments that they need to just add to the list they return. The code that completes HalfOp combinations, which handle the different precendence under perl < 5.14, wasn't accounting for this, so some arguments could get lost. Fixes RT#132455
Codecov Report
@@ Coverage Diff @@
## master #55 +/- ##
==========================================
- Coverage 88.78% 88.75% -0.03%
==========================================
Files 36 36
Lines 3583 3583
Branches 984 984
==========================================
- Hits 3181 3180 -1
Misses 62 62
- Partials 340 341 +1
Continue to review full report at Codecov.
|
|
I'm getting fails on Perl < 5.14 on Travis. https://travis-ci.org/github/tobyink/p5-type-tiny/builds/681573512 |
|
Oops. Should be fixed by #56. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parameterized type subs will receive one argument with their arguments,
but may also get additional arguments that they need to just add to the
list they return. The code that completes HalfOp combinations, which
handle the different precendence under perl < 5.14, wasn't accounting
for this, so some arguments could get lost.
Fixes RT#132455