Type::Library declare: Unshadow $t, allowing outer $t to be modified #58
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi again! This one I'm afraid I don't have a test for; a coworker pointed it out to me and I didn't want it to get lost. It looks like a stray 'my' was left here, shadowing the outer
$t
so this block doesn't have an effect.I think we tripped it when a
namespace::clean
was placed after the-declare
, which doesn't make sense anyway, as those declared types aren't supposed to be removed. One would expect a busted type library in that case, it just happened to work fine with an older Type::Tiny. We fixed that, but this line still stood out as "is this right?"