[1868Wyoming] train cross-buy is not working

[Rupre]

The game is not allowing FE&MV to buy a 4+3 train from LNP for $324. The message is "Not a buyable train". Why say the train is available and allow me to enter the price; then reject with a message?

https://18xx.games/game/162539?action=440

[michaeljb]

From experimenting in hotseat a little more, all trains except 4+3 trains can be cross-bought from other companies. Not sure what would cause that but it’s at least a lead for when I have time to properly debug this.

[michaeljb]

• the base code determined that both the 4 and 4+3 variants should be available for other corporations to buy (other code made sure the UI only presented the 4+3, which is how the train was bought initially by LNP)
• FE&MV has $325, more than the face value of a 4-train ($300) but less than the 4+3's face value ($360)
• the 1868 Wyoming code assumes that if two variants are available, we're buying from the depot
• when buying from the depot, we can only buy a train we can afford or the cheapest, so the 4+3 gets filtered out

The fix in #10793 is to simply return the single active variant if the train is in fact owned by a company instead of the depot.