[1841] Shares of a major have disappeared

[Titanrich]

1841
Game 132194

The IFAI corporation just completed its turn in the OR. At one point, before a redo, two shares of SFLi were sold. That was not the path I wanted so I hit redo, and passed sell corporate shares. Then I merged IFAI with SFL to create CTDA. The text says three shares of SFLi were moved to the CTDA treasury, but only one shows up. The corporation SFLi is next to run, and it shows only 8 corporate shares in this game.

2 shares of SFLi are missing, should be part of CTDA treasury.

Rich Atwater

15:24] Moving 30% of shares of SFLi from IFAI to CTDA treasury

If your game is "Multiplayer", provide the link to the game. Copy the link from your browser which will look something like https://18xx.games/game/31337

• (optional) Provide a link to the specific action that triggered the bug using the Game tab and History navigation arrows. Copy the resulting link from your browser which will look something like https://18xx.games/game/31337?action=42

If your game is "Hotseat", provide a link to your raw game data by using the Tools tab and Copy Game Data.

Paste that data into a github gist and share the resulting link which will look something like https://gist.github.com/[your_name]/[some_letters].

-->

How to Reproduce the Bug?

Which Browser / Platform?

[roseundy]

This is an ugly corner case. There appears to be two problems here:

1. The presidency of SFLi should remain with the new corporation. In this case it doesn't - the code moves the presidency to Titanrich
2. When it does move the presidency, the transfer_shares method in SharePool appears to only handle a president change correctly only if only the president share is being moved, not a bundle of multiple shares that includes the president's share.