Fix buying president share from market

[crericha]

Fix for #1469. First verify the player has a share and is thus able to exchange for the president's share. Then update the president's share bundle to a 10% partial when being bought out of the market, so the exchange logic works correctly. This fix also removes the old logic that didn't work correctly.

[tobymao]

sounds good we can keep it then

…

On Thu, Sep 10, 2020 at 4:06 PM crericha ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In lib/engine/step/g_1846/buy_sell_par_shares.rb <#1637 (comment)>: > - percent = 10 - bundle = ShareBundle.new(bundle.shares, percent) + bundle = bundle.to_bundle + corporation = bundle.corporation + + if corporation.receivership? && bundle.presidents_share + return false if entity.num_shares_of(corporation).zero? + + bundle = ShareBundle.new(bundle.shares, 10) + end + + super(entity, bundle) In stock Ruby, super with no arguments works great; however, I confirmed I need to explicitly pass the parameters here. Perhaps a limitation/bug with Opal? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#1637 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB6TF2TRDB3JLQLBMLC26RDSFFLWFANCNFSM4REME3FA> .