Convert SIGNUM function to SIGN (#3007)

tobymao · Feb 22, 2024 · 9079ead · 9079ead
1 parent 9840496
commit 9079ead
Show file tree

Hide file tree

Showing 5 changed files with 23 additions and 3 deletions.
diff --git a/sqlglot/dataframe/sql/functions.py b/sqlglot/dataframe/sql/functions.py
@@ -210,7 +210,7 @@ def sec(col: ColumnOrName) -> Column:
 
 
 def signum(col: ColumnOrName) -> Column:
-    return Column.invoke_anonymous_function(col, "SIGNUM")
+    return Column.invoke_expression_over_column(col, expression.Sign)
 
 
 def sin(col: ColumnOrName) -> Column:

diff --git a/sqlglot/expressions.py b/sqlglot/expressions.py
@@ -5313,6 +5313,10 @@ class SHA2(Func):
     arg_types = {"this": True, "length": False}
 
 
+class Sign(Func):
+    _sql_names = ["SIGN", "SIGNUM"]
+
+
 class SortArray(Func):
     arg_types = {"this": True, "asc": False}
 

diff --git a/sqlglot/optimizer/annotate_types.py b/sqlglot/optimizer/annotate_types.py
@@ -191,6 +191,7 @@ class TypeAnnotator(metaclass=_TypeAnnotator):
             exp.DateToDi,
             exp.Floor,
             exp.Levenshtein,
+            exp.Sign,
             exp.StrPosition,
             exp.TsOrDiToDi,
         },

diff --git a/tests/dataframe/unit/test_functions.py b/tests/dataframe/unit/test_functions.py
@@ -280,9 +280,9 @@ def test_sec(self):
 
     def test_signum(self):
         col_str = SF.signum("cola")
-        self.assertEqual("SIGNUM(cola)", col_str.sql())
+        self.assertEqual("SIGN(cola)", col_str.sql())
         col = SF.signum(SF.col("cola"))
-        self.assertEqual("SIGNUM(cola)", col.sql())
+        self.assertEqual("SIGN(cola)", col.sql())
 
     def test_sin(self):
         col_str = SF.sin("cola")

diff --git a/tests/dialects/test_presto.py b/tests/dialects/test_presto.py
@@ -1142,3 +1142,18 @@ def test_to_char(self):
                 "presto": "DATE_FORMAT(ts, '%y')",
             },
         )
+
+    def test_signum(self):
+        self.validate_all(
+            "SIGN(x)",
+            read={
+                "presto": "SIGN(x)",
+                "spark": "SIGNUM(x)",
+                "starrocks": "SIGN(x)",
+            },
+            write={
+                "presto": "SIGN(x)",
+                "spark": "SIGN(x)",
+                "starrocks": "SIGN(x)",
+            },
+        )