fix(athena): Fix CREATE TABLE properties, STRING data type (#3129)

sqlglot/dialects/athena.py

@@ -1,5 +1,6 @@
 from __future__ import annotations
 
+from sqlglot import exp
 from sqlglot.dialects.trino import Trino
 from sqlglot.tokens import TokenType
 
@@ -10,3 +11,27 @@ class Parser(Trino.Parser):
             **Trino.Parser.STATEMENT_PARSERS,
             TokenType.USING: lambda self: self._parse_as_command(self._prev),
         }
+
+    class Generator(Trino.Generator):
+        PROPERTIES_LOCATION = {
+            **Trino.Generator.PROPERTIES_LOCATION,
+            exp.LocationProperty: exp.Properties.Location.POST_SCHEMA,
+        }
+
+        TYPE_MAPPING = {
+            **Trino.Generator.TYPE_MAPPING,
+            exp.DataType.Type.TEXT: "STRING",
+        }
+
+        TRANSFORMS = {
+            **Trino.Generator.TRANSFORMS,
+            exp.FileFormatProperty: lambda self, e: f"'FORMAT'={self.sql(e, 'this')}",
+        }
+
+        def property_sql(self, expression: exp.Property) -> str:
+            return (
+                f"{self.property_name(expression, string_key=True)}={self.sql(expression, 'value')}"
+            )
+
+        def with_properties(self, properties: exp.Properties) -> str:
+            return self.properties(properties, prefix=self.seg("TBLPROPERTIES"))

tests/dialects/test_athena.py

@@ -14,3 +14,7 @@ def test_athena(self):
             some_function(1)""",
             check_command_warning=True,
         )
+
+        self.validate_identity(
+            "CREATE TABLE IF NOT EXISTS t (name STRING) LOCATION 's3://bucket/tmp/mytable/' TBLPROPERTIES ('table_type'='iceberg', 'FORMAT'='parquet')"
+        )