Fix(snowflake): make FILE_FORMAT option always be uppercase in COPY INTO

tobymao · May 4, 2024 · fc979a0 · fc979a0
1 parent b77709e
commit fc979a0
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/sqlglot/dialects/snowflake.py b/sqlglot/dialects/snowflake.py
@@ -1042,8 +1042,8 @@ def struct_sql(self, expression: exp.Struct) -> str:
             return self.func("OBJECT_CONSTRUCT", *flatten(zip(keys, values)))
 
         def copyparameter_sql(self, expression: exp.CopyParameter) -> str:
-            option = self.sql(expression, "this")
-            if option.upper() == "FILE_FORMAT":
+            option = self.sql(expression, "this").upper()
+            if option == "FILE_FORMAT":
                 values = self.expressions(expression, key="expression", flat=True, sep=" ")
                 return f"{option} = ({values})"
 

diff --git a/tests/dialects/test_snowflake.py b/tests/dialects/test_snowflake.py
@@ -1833,6 +1833,7 @@ def test_try_cast(self):
 
     def test_copy(self):
         self.validate_identity(
+            """COPY INTO mytable (col1, col2) FROM 's3://mybucket/data/files' FILES = ('file1', 'file2') PATTERN = 'pattern' file_format = (FORMAT_NAME = my_csv_format NULL_IF = ('str1', 'str2')) PARSE_HEADER = TRUE""",
             """COPY INTO mytable (col1, col2) FROM 's3://mybucket/data/files' FILES = ('file1', 'file2') PATTERN = 'pattern' FILE_FORMAT = (FORMAT_NAME = my_csv_format NULL_IF = ('str1', 'str2')) PARSE_HEADER = TRUE"""
         )
         self.validate_identity(