Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(athena): Fix CREATE TABLE properties, STRING data type #3129

Merged
merged 1 commit into from
Mar 12, 2024
Merged

fix(athena): Fix CREATE TABLE properties, STRING data type #3129

merged 1 commit into from
Mar 12, 2024

Conversation

VaggelisD
Copy link
Collaborator

Fixes #3126

georgesittas
georgesittas approved these changes Mar 12, 2024
View reviewed changes
Copy link
Collaborator

@georgesittas georgesittas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - just one comment

sqlglot/dialects/athena.py Show resolved Hide resolved
@georgesittas georgesittas merged commit 94b5a2f into main Mar 12, 2024
5 checks passed
@georgesittas georgesittas deleted the vaggelisd/athena_iceberg branch March 12, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@georgesittas georgesittas georgesittas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Athena Iceberg Tables parsing issue
2 participants
@VaggelisD @georgesittas