Fix: properly parse/generate duckdb MAP {..} syntax, annotate MAPs #3241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgesittas
commented
Mar 28, 2024
| @@ -3675,3 +3628,51 @@ def convert_sql(self, expression: exp.Convert) -> str: | |||
| transformed = cast(this=value, to=to, safe=safe) | |||
|
|
|||
| return self.sql(transformed) | |||
|
|
|||
| def _jsonpathkey_sql(self, expression: exp.JSONPathKey) -> str: | |||
There was a problem hiding this comment.
Nothing to see here - just moved these underscore methods to the bottom of the generator file so they're grouped like helper methods. The only change is the TRANSFORMS entry.
tobymao
approved these changes
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference: https://duckdb.org/docs/sql/data_types/map.html