Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for CREATE STREAMLIT #3516

Closed
yingw787 opened this issue May 20, 2024 · 1 comment · Fixed by #3519
Closed

Add support for CREATE STREAMLIT #3516

yingw787 opened this issue May 20, 2024 · 1 comment · Fixed by #3519

Comments

@yingw787
Copy link
Contributor

Is your feature request related to a problem? Please describe.

After Snowflake's acquisition of Streamlit, they updated their query layer in order to support CREATE STREAMLIT queries: https://docs.snowflake.com/en/sql-reference/sql/create-streamlit, which is very similar to CREATE WAREHOUSE in that it is a creatable / "create-able" with a number of different attributes. From empirical testing, Snowflake sticks things into its query layer instead of exposing a REST API, so you manage various Streamlit applications using SQL. Would love to have STREAMLIT as a registered identifier.

I can create a PR for this later tonight. I'd like to engage in a longer-term commitment to upstreaming to sqlglot on a regular basis (since my role involves a lot of this stuff). CC: @whummer

Describe the solution you'd like

Running:

parse_one("CREATE STREAMLIT x")

Results in:

Create(
  this=Table(
    this=Identifier(this=x, quoted=False)),
  kind=STREAMLIT)

or similar, as implemented in #3510 and follow-up.

Describe alternatives you've considered

Upstreaming this change for improved tokenization support.

@georgesittas
Copy link
Collaborator

I can create a PR for this later tonight.

Would be much appreciated. Thanks for these contributions 👍

Btw, feel free to reach out in our Slack channel if you wanna chat about contributions or just in general.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants