Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(snowflake): implement parsing logic for SHOW TABLES #2913

Merged
merged 6 commits into from
Feb 5, 2024
Merged

Feat(snowflake): implement parsing logic for SHOW TABLES #2913

merged 6 commits into from
Feb 5, 2024

Conversation

tekumara
Copy link
Contributor

@tekumara tekumara commented Feb 5, 2024

@tekumara tekumara mentioned this pull request Feb 5, 2024
Closed
georgesittas
georgesittas approved these changes Feb 5, 2024
View reviewed changes
Copy link
Collaborator

@georgesittas georgesittas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tekumara! Just one small suggestion, mostly for consistency.

sqlglot/dialects/snowflake.py Outdated Show resolved Hide resolved
@georgesittas georgesittas changed the title feat: SHOW TABLES (Snowflake) Feat(snowflake): SHOW TABLES Feb 5, 2024
@georgesittas georgesittas changed the title Feat(snowflake): SHOW TABLES Feat(snowflake): implement parsing logic for SHOW TABLES Feb 5, 2024
@georgesittas georgesittas merged commit d262139 into tobymao:main Feb 5, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@georgesittas georgesittas georgesittas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tekumara @georgesittas