Fix: Ignore Identifier nodes in the diffing algorithm #3065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobymao
approved these changes
Mar 1, 2024
izeigerman
force-pushed
the
fix-ignore-identifier-in-diff
branch
from
64d435d
to
9d82ca6
Compare
izeigerman
force-pushed
the
fix-ignore-identifier-in-diff
branch
from
9d82ca6
to
1ed2975
Compare
georgesittas
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Identifier node is too granular for diffing and doesn't posses a relevant context on its own. Because of this the resulting edit scripts are often too noisy and sometimes misleading.
The problem becomes more pronounced when the same identifier is repeated many times throughout a query, which is often the case when projections are fully qualified.