-
Notifications
You must be signed in to change notification settings - Fork 591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(duckdb): add support for exp.ArrayJoin #3102
Conversation
tests/dialects/test_duckdb.py
Outdated
@@ -666,6 +666,13 @@ def test_duckdb(self): | |||
"""SELECT i FROM GENERATE_SERIES(0, 12) AS _(i) ORDER BY i ASC""", | |||
) | |||
|
|||
self.validate_all( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can delete this test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
@@ -678,6 +678,7 @@ def test_snowflake(self): | |||
write={ | |||
"spark": "ARRAY_JOIN(x, '')", | |||
"snowflake": "ARRAY_TO_STRING(x, '')", | |||
"duckdb": "ARRAY_TO_STRING(x, '')", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add a test here read={
"duckdb": "ARRAY_TO_STRING(x, '')"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
thanks! |
Noticed this while transpiling a Snowflake query into DuckDB;
AFAIS equivalent of
ArrayJoin
in DuckDB -luckly- would bearray_to_string
.I'm not sure I've totally understand the test structure though, should there be cases for each dialect or is it sufficient enough like this?