Fix: copy all arg keys, including those set to None #3108
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following behavior was observed after the latest
__deepcopy__
changes:The root issue here is that we don't copy over arg keys with
None
values anymore due to using the set method for leaf nodes, meaning that the original and the copied AST may now have differentargs
dicts.(The
self.assertEqual(query, query.copy())
test passes in main - I added it to future-proof__deepcopy__
,__eq__
)