Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(duckdb): add support for positional joins #3111

Merged
merged 1 commit into from
Mar 9, 2024

Conversation

georgesittas
Copy link
Collaborator

@georgesittas georgesittas commented Mar 9, 2024

Fixes #3109

I didn't add TokenType.POSITIONAL to ID_VAR_TOKENS on purpose since DuckDB treats it as a reserved keyword:

D select positional;
Error: Parser Error: syntax error at or near ";"
LINE 1: select positional;
                         ^
D select 1 positional;
Error: Parser Error: syntax error at or near "positional"
LINE 1: select 1 positional;
                 ^
D select 1 as positional;
┌────────────┐
│ positional │
│   int32    │
├────────────┤
│          1 │
└────────────┘
D with t as (select 1 as positional) select positional from t;
Error: Parser Error: syntax error at or near "from"
LINE 1: ...ect 1 as positional) select positional from t;
                                                  ^

@georgesittas georgesittas merged commit 804af34 into main Mar 9, 2024
5 checks passed
@georgesittas georgesittas deleted the jo/duckdb_positional_join branch March 9, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DuckDB POSITIONAL JOIN syntax
2 participants